Add support for Huion 1060 Plus #3408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
previously approved these changes
Sep 15, 2024
Kuuuube
previously approved these changes
Sep 15, 2024
Kuuuube
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is certainly an interesting one. It also seems identical to the Monoprice 10594. Both tablets require WinUSB, it just originally slipped past review on #2337. (the only notable difference is that this one has more auxiliary buttons)
https://discord.com/channels/615607687467761684/992875926654304426/992881131257069608
https://discord.com/channels/615607687467761684/992875926654304426/992880866302906489
I'm not sure all variants will have that string on index 6 for either of those tablets as we have seen some weird behaviour before, but we won't know for sure without tanking the possibly breaking change.
If we don't want to take any risks I can instead remove the string changes and simply add to the TABLETS.md that it'll detect as the monoprice and the last 4 auxiliary buttons won't be supported, but the perks of submitting this as is is that if it is breaking we will get information on a tablet that is otherwise problematic (there has been even more matches of this tablet falsely, so narrowing down false detections will help improve tablet support)
Old string dump is the second link above
Verification: https://discord.com/channels/615607687467761684/789348845372178482/1268664084740444303
Diagnostic: https://discord.com/channels/615607687467761684/789348845372178482/1268655991071969290
Can't find reasoning behind it but its already on the TABLETS.md