Skip to content

Conversation

@adhdandy
Copy link
Contributor

@adhdandy adhdandy commented Apr 16, 2024

Fixes #3280.

Proof tablet-data.txt

@jamesbt365
Copy link
Member

Tablet data as proof doesn't verify much as it doesn't necessarily prove what the tablet is doing, could you do separate data recordings for the different functions of the tablet?

@jamesbt365 jamesbt365 added configuration Adds or modifies a tablet configuration needs-forward-port PR or its features needs to be ported to development branch labels Apr 16, 2024
@adhdandy
Copy link
Contributor Author

Tablet data as proof doesn't verify much as it doesn't necessarily prove what the tablet is doing, could you do separate data recordings for the different functions of the tablet?

You mean separate recordings for the tablet buttons, pen pressure / buttons, movement etc.?

@jamesbt365
Copy link
Member

Yes.

@adhdandy
Copy link
Contributor Author

@InfinityGhost InfinityGhost requested a review from jamesbt365 July 30, 2024 20:48
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still prefer a different naming scheme to avoid the breaking change if any other tablets use this parser in the future.

It likely accomodates all Veikk tablets that currently use the SkipByteTabletReportParser.

Parser looks fine.

@adhdandy
Copy link
Contributor Author

I'd still prefer a different naming scheme to avoid the breaking change if any other tablets use this parser in the future.

It likely accomodates all Veikk tablets that currently use the SkipByteTabletReportParser.

Parser looks fine.

That's seems to be all Veikk Axx tablets, except those v2 models that use VeikkReportParser instead. The naming is a bit confusing, because there is also a VeikkV2ReportParser which is used instead by the S640. I could rename VeikkA15ReportParser to VeikkV1ReportParser or VeikkAxxV1ReportParser maybe?

@jamesbt365
Copy link
Member

VeikkV1ReportParser should be fine for now. We'll be improving the naming scheme of our parsers at some point.

@jamesbt365
Copy link
Member

Is tilt out of scope?

@adhdandy
Copy link
Contributor Author

adhdandy commented Aug 2, 2024

Is tilt out of scope?

I only have the old A15 without tilt, so I don't know how that works.

Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any parser duplication issues can be solved later (given that its already fairly messy)

@jamesbt365 jamesbt365 merged commit 163ea46 into OpenTabletDriver:0.6.x Aug 3, 2024
@jamesbt365 jamesbt365 removed the needs-forward-port PR or its features needs to be ported to development branch label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration Adds or modifies a tablet configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants