-
-
Notifications
You must be signed in to change notification settings - Fork 442
Fix aux button support on Veikk A15 tablets #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 4b60c67.
|
Tablet data as proof doesn't verify much as it doesn't necessarily prove what the tablet is doing, could you do separate data recordings for the different functions of the tablet? |
You mean separate recordings for the tablet buttons, pen pressure / buttons, movement etc.? |
|
Yes. |
jamesbt365
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still prefer a different naming scheme to avoid the breaking change if any other tablets use this parser in the future.
It likely accomodates all Veikk tablets that currently use the SkipByteTabletReportParser.
Parser looks fine.
That's seems to be all Veikk Axx tablets, except those v2 models that use VeikkReportParser instead. The naming is a bit confusing, because there is also a VeikkV2ReportParser which is used instead by the S640. I could rename VeikkA15ReportParser to VeikkV1ReportParser or VeikkAxxV1ReportParser maybe? |
|
|
|
Is tilt out of scope? |
I only have the old A15 without tilt, so I don't know how that works. |
gonX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any parser duplication issues can be solved later (given that its already fairly messy)
Fixes #3280.
Proof tablet-data.txt