Skip to content

Use INPUT_PROP_POINTER for tablets as suggested by kernel docs #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
X9VoiD merged 2 commits into from
Sep 30, 2023
Merged

Use INPUT_PROP_POINTER for tablets as suggested by kernel docs #2941

X9VoiD merged 2 commits into from
Sep 30, 2023

Conversation

@gonX
Copy link
Member

@gonX gonX commented Sep 30, 2023

Depends on (extends) #2940

https://docs.kernel.org/input/event-codes.html#tablets :

2.4.4. Tablets
For new hardware, both INPUT_PROP_DIRECT and INPUT_PROP_POINTER should be set.

There does not seem to be a functional change on my system with this PR.

gonX added 2 commits September 30, 2023 10:57
@gonX
Fix misuse of INPUT_PROP_DIRECT
58d6949 
Previously, we would actually be sending EnableType(EV_KEY) rather than EnableProp(INPUT_PROP_DIRECT) because of the overlap of values
@gonX
Fix Linux Artist Mode tablet property reporting
46a5511 
Kernel docs suggest that tablets should report both 'INPUT_PROP_DIRECT' as well as 'INPUT_PROP_POINTER'
@gonX gonX added linux/gtk Affects the Linux platform enhancement New feature or request labels Sep 30, 2023
@X9VoiD X9VoiD merged commit 6c4ffac into OpenTabletDriver:master Sep 30, 2023
@gonX gonX deleted the use-input-prop-pointer branch September 30, 2023 10:03
@X9VoiD X9VoiD added the needs-backport PR or its features needs to be backported to stable branch label Dec 10, 2023
@X9VoiD X9VoiD mentioned this pull request Dec 10, 2023
Merged
@X9VoiD X9VoiD removed the needs-backport PR or its features needs to be backported to stable branch label Dec 10, 2023
@gonX gonX added the backport-added A backport is already merged label Jan 22, 2025
@gonX gonX added the desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-added A backport is already merged desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. enhancement New feature or request linux/gtk Affects the Linux platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonX @X9VoiD