Add identifier for Deco 01 V2 #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not happy with the way that you have done that. Export a diagnostic and send it here as well as a string dump. |
Contributor
Author
Member
|
This just seems like a 200lpi having no real difference to the 100lpi variant and i don't know if this would break other variants but i'll leave that to void. |
Contributor
Author
|
Sorry, the diagnostics.json I just sent is the wrong one. Here is the correct one. |
Member
|
You rebased to the wrong branch. |
5e3a185 to
f2b7e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Deco 01 V2 can only use the upper left 1/4. So it should use variant 2 configuration.
The difference between them seems to be device string at the index 5.
device strings: