Fixed aux buttons for Veikk A30 V2 #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b09fb5c to
879af32
Compare
X9VoiD
requested changes
Jun 5, 2022
OpenTabletDriver.Configurations/Parsers/Veikk/VeikkAuxReport.cs
Outdated
Show resolved
Hide resolved
X9VoiD
approved these changes
Jun 5, 2022
Member
X9VoiD
left a comment
There was a problem hiding this comment.
If a VEIKK tablet has more than 4 buttons then we can just extend this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamesbt365 said in this PR #2216 that the aux buttons might not be working due to the OEM drivers still being installed, but that's not the case (they are also broken on a fresh windows 10 install).
I reverse-engineered the OEM driver and it turns out the tablet needs 3 initial reports (one for the digitizer, one for the aux buttons, one for the touchpad). I've added a parser that can parse the aux button reports. I don't know if that solution works for other Veikk tablets as well, it might fix #1854.