Add eraser support for intuos1 #2260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractQbit
suggested changes
May 22, 2022
OpenTabletDriver.Configurations/Parsers/Wacom/Intuos1/Intuos1ReportParser.cs
Outdated
Show resolved
Hide resolved
jamesbt365
approved these changes
May 22, 2022
Member
|
What happens to the V1 parser from here? |
X9VoiD
requested changes
Nov 7, 2022
Member
X9VoiD
left a comment
There was a problem hiding this comment.
Is there no more users of IntuosV1? Should delete it if there's none since Intuos1 is directly compatible with V1 (i hate the parser name scheme we have if there even is one lol).
OpenTabletDriver.Configurations/Parsers/Wacom/Intuos1/Intuos1ToolReport.cs
Outdated
Show resolved
Hide resolved
Member
Author
No there are still many tablets that use it. Some Wacom tablets should be split off similar to this PR but even then there's some other tablets that use it. |
Merged
Member
|
Superseded by #2557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.