Add absolute wheel (ring) support #2256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes an example configuration for the PTH-851 as well as a nonworking implementation for Linux.
| "MouseButtons": null, | ||
| "Touch": null | ||
| "Touch": null, | ||
| "MaxWheelPosition": 71 |
Member
There was a problem hiding this comment.
Would prefer another specification type for this instead, so that this could be expanded on.
Member
Author
|
Superseded by #3497 which should get forward ported once the wheel API has matured.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1367 - code needs a bit of cleanup (magic numbers into vars) and we likely need some UX configurables.
The idea is absolute wheels should just work:tm: without having to set anything, but UX additions are welcome of course. You can PR to my branch of course.
As the code is right now, it's not doing what I want.
I think libinput is handling the events differently because the OTD device is considered a pen and not a pad. We might have to split events into 2 devices here, one for the pen itself and one for the pad if fixing libinput tags (via quirks?) doesn't fix it
Leaving as draft as I'm not entirely satisfied with it yet, but people can take a look and tell me if there's anything glaringly wrong. I have no plans of personally including relative wheel support, though once again you can PR to my branch.