Fix: Sentry reports every minute how many sessions it has seen#14
Merged
TrueBrain merged 1 commit intoOpenTTD:mainfrom Jun 12, 2023
Merged
Fix: Sentry reports every minute how many sessions it has seen#14TrueBrain merged 1 commit intoOpenTTD:mainfrom
TrueBrain merged 1 commit intoOpenTTD:mainfrom
Conversation
glx22
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
send_client_reports, this sends a report every minute about activity. And all that for seeing a percentage of crashes sessions on a dashboard.That really is not worth it .. not in balance of bandwidth, but also not in the balance of privacy. Disable auto tracking of sessions.
PS: if the 60 seconds was configurable, it would have been nice .. like once an hour is more than sufficient enough to report this information.