Fix: Sentry emit an (empty) report every minute#13
Merged
TrueBrain merged 1 commit intoOpenTTD:mainfrom Jun 12, 2023
Merged
Conversation
glx22
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the new infrastructure, I noticed that every minute all services send a report to Sentry. After some investigation, turns out that this is the "client report".
I have a bit of an issues with this reporting. This client report contains how many events were missed, for statistical goals. Which on its own is fine. But .. it also sends this report even if there are no missed events at all. And it sends this every minute.
So this really smells like tracking, more than something that is actually useful. I am sure it was added with the best intentions, but having all services that use Sentry report in every minute with an empty report feels ... very ... wrong? bad? silly? useless?
Anyway, enough ranting. Let's just disable the
trackingreporting, and be done with it.Edit: I have to nuance my rant, it only does this when there are actual dismissed events; it doesn't send empty reports. It is still very weird this happens every minute when there are.