Add: helper to keep strong references to created tasks#12
Merged
TrueBrain merged 1 commit intoOpenTTD:mainfrom Feb 19, 2023
Merged
Add: helper to keep strong references to created tasks#12TrueBrain merged 1 commit intoOpenTTD:mainfrom
TrueBrain merged 1 commit intoOpenTTD:mainfrom
Conversation
frosch123
reviewed
Feb 19, 2023
Python's asyncio.create_task() keeps an internal weak reference. In result, the GC can remove the task if the returning task is not tracked. But it is much more convenient to use that function as a fire&forget, and to not always have to track it. So, instead of having to add code in other places to send these tasks to a background-queue, take over the whole factory and create a strong reference for every task created.
145ba32 to
c5e7507
Compare
frosch123
approved these changes
Feb 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's asyncio.create_task() keeps an internal weak reference. In result, the GC can remove the task if the returning task is not tracked.
But it is much more convenient to use that function as a fire&forget, and to not always have to track it.
So, instead of having to add code in other places to send these tasks to a background-queue, take over the whole factory and create a strong reference for every task created.