Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Migrate page-header/breadcrumbs tests to testing-library#8

Merged
JacobMGEvans merged 2 commits intoOpenSourceRaidGuild:masterfrom
TheGallery:thegallery
Dec 16, 2020
Merged

Migrate page-header/breadcrumbs tests to testing-library#8
JacobMGEvans merged 2 commits intoOpenSourceRaidGuild:masterfrom
TheGallery:thegallery

Conversation

@TheGallery
Copy link
Copy Markdown

@TheGallery TheGallery commented Dec 16, 2020

Fixes #7

There was only one file that needed a migration to testing-library. I took the liberty of cleaning up another file too

Copy link
Copy Markdown

@Aprillion Aprillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@nobrayner nobrayner changed the title Fix #7 — TheGallery Migrate page-header/breadcrumbs tests to testing-library Dec 16, 2020
@JacobMGEvans JacobMGEvans merged commit 8605b33 into OpenSourceRaidGuild:master Dec 16, 2020
@TheGallery TheGallery deleted the thegallery branch January 7, 2021 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate page-header/breadcrumbs tests to testing-library

3 participants