Skip to content

Fix display of comments count when comment has been moderated#349

Merged
moustachu merged 2 commits into0.12-stablefrom
Fix/comments-count-on-card
Jan 17, 2019
Merged

Fix display of comments count when comment has been moderated#349
moustachu merged 2 commits into0.12-stablefrom
Fix/comments-count-on-card

Conversation

@armandfardeau
Copy link
Copy Markdown
Collaborator

@armandfardeau armandfardeau commented Nov 28, 2018 •
edited
Loading

🎩 What? Why?

Fix comments count when a comment has been moderated

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add system test for proposals
  • Add system test for meetings

@ghost ghost assigned armandfardeau Nov 28, 2018
@ghost ghost added the needs-review label Nov 28, 2018
@armandfardeau armandfardeau force-pushed the Fix/comments-count-on-card branch from 545dc92 to 6720a71 Compare November 28, 2018 20:24
@armandfardeau armandfardeau changed the title fix display of comments count when comment has been moderated Fix display of comments count when comment has been moderated Nov 28, 2018
@armandfardeau
Copy link
Copy Markdown
Collaborator Author

armandfardeau commented Nov 28, 2018

@moustachu Partial From circle-ci website

System Outage - components affected: CircleCI 2.0, macOS 2.0 Builds
Updated 12 min ago - 2.0 Jobs not running: Our engineers are working to determine the cause of the failure. We will post an update within 20 minutes.

I suggest we double check this one.

@armandfardeau armandfardeau changed the title Fix display of comments count when comment has been moderated WIP: Fix display of comments count when comment has been moderated Nov 28, 2018
@armandfardeau armandfardeau changed the title WIP: Fix display of comments count when comment has been moderated Fix display of comments count when comment has been moderated Dec 4, 2018
lu-hamani
lu-hamani previously requested changes Dec 4, 2018
View reviewed changes
Copy link
Copy Markdown

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works for issue #215
Unfortunately it doesn't solve issue #300 . Maybe I am not testing the fix properly. Still here are my screenshots.
screenshot 2018-12-04 at 12 14 26
screenshot 2018-12-04 at 12 14 32

@armandfardeau armandfardeau dismissed lu-hamani’s stale review December 5, 2018 12:38

Not pertinent anymore

@stale
Copy link
Copy Markdown

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Feel free to notify @lu-hamani.

@stale stale bot added the wontfix under the radar label Jan 10, 2019
@lu-hamani lu-hamani removed the wontfix under the radar label Jan 10, 2019
@lu-hamani lu-hamani added this to the Late fixes 0.12 milestone Jan 17, 2019
@moustachu moustachu merged commit 921bf14 into 0.12-stable Jan 17, 2019
@ghost ghost removed the needs-review label Jan 17, 2019
@lu-hamani
Copy link
Copy Markdown

lu-hamani commented Feb 25, 2019

@armandfardeau
To send to BCN => decidim#3651

@lu-hamani lu-hamani mentioned this pull request Feb 25, 2019
Closed
13 tasks
@paulinebessoles paulinebessoles deleted the Fix/comments-count-on-card branch October 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moustachu moustachu Awaiting requested review from moustachu

1 more reviewer

@lu-hamani lu-hamani lu-hamani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@armandfardeau armandfardeau

Labels

None yet

Projects

None yet

Milestone

0.16-stable-debug II

Development

Successfully merging this pull request may close these issues.

3 participants

@armandfardeau @lu-hamani @moustachu