Use actual Spice86 icon on GitHub Pages; remove DNPCS from driver tables#58
Conversation
…rom tables Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/0a0fef41-1853-4969-8542-6b8f5baf00b4 Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates project documentation/GitHub Pages to remove the (apparently non-existent) DNPCS driver from remapping tables and to display the real Spice86 application icon on the site’s Spice86 link card.
Changes:
- Remove DNPCS from the Driver Remapping tables in
README.mdanddocs/index.html. - Update README prose to drop DNPCS from the list of music drivers.
- Replace the Spice86 🌶️ emoji in GitHub Pages with an
<img>pointing at the Spice86.ico.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Removes DNPCS from the driver-remapping documentation and updates the narrative description accordingly. |
| docs/index.html | Removes DNPCS row from the driver-remapping table and swaps the Spice86 emoji for an icon image. |
| | `cs5` | `0x0800` | Interrupt handlers (custom segment replacing default 0xF000) | None (declared for address reference) | | ||
|
|
||
| `cs3` and `cs4` share address `0xE000`. In `DriverLoadToolbox`, PCM drivers (DNPCS2, DNSBP) load at `DRIVER2_SEGMENT = 0xE000`, and music drivers (DNPCS, DNMID) load at `DRIVER3_SEGMENT = 0xF000`. The MT-32 overrides in `MT32DriverCode.cs` use hardcoded `0xF000` (3 functions), not any `cs` field. | ||
| `cs3` and `cs4` share address `0xE000`. In `DriverLoadToolbox`, PCM drivers (DNPCS2, DNSBP) load at `DRIVER2_SEGMENT = 0xE000`, and music drivers (DNMID) load at `DRIVER3_SEGMENT = 0xF000`. The MT-32 overrides in `MT32DriverCode.cs` use hardcoded `0xF000` (3 functions), not any `cs` field. |
There was a problem hiding this comment.
This paragraph now states that only DNMID is loaded at DRIVER3_SEGMENT = 0xF000, but the implementation/docs in src/Cryogenic/DriverLoadToolbox.cs still describe remapping both DNPCS and DNMID to DRIVER3_SEGMENT (e.g., enum DriverIndex includes DNPCS, and the XML remarks list DNPCS, DNMID → 0xF000). Either update the code/docs to drop DNPCS everywhere (if it truly doesn’t exist) or adjust this README text so it matches the actual driver-remapping logic.
| `cs3` and `cs4` share address `0xE000`. In `DriverLoadToolbox`, PCM drivers (DNPCS2, DNSBP) load at `DRIVER2_SEGMENT = 0xE000`, and music drivers (DNMID) load at `DRIVER3_SEGMENT = 0xF000`. The MT-32 overrides in `MT32DriverCode.cs` use hardcoded `0xF000` (3 functions), not any `cs` field. | |
| `cs3` and `cs4` share address `0xE000`. In `DriverLoadToolbox`, PCM drivers (DNPCS2, DNSBP) load at `DRIVER2_SEGMENT = 0xE000`, and drivers `DNPCS` and `DNMID` load at `DRIVER3_SEGMENT = 0xF000`. The MT-32 overrides in `MT32DriverCode.cs` use hardcoded `0xF000` (3 functions), not any `cs` field. |
| <a href="https://github.com/OpenRakis/Spice86" class="bg-gray-900 rounded-lg p-6 hover-glow block"> | ||
| <div class="flex items-center mb-3"> | ||
| <span class="text-3xl mr-3">🌶️</span> | ||
| <img src="https://raw.githubusercontent.com/OpenRakis/Spice86/master/src/Spice86/Views/Assets/Spice86.ico" class="w-8 h-8 mr-3" alt="Spice86"> |
There was a problem hiding this comment.
This icon is hot-linked from another repo’s default branch (.../Spice86/master/...). That’s a brittle dependency for GitHub Pages: if the branch name or path changes, the site will show a broken image. Consider vendoring the icon into this repo (e.g., under docs/assets/) as part of the Pages build, or pinning the URL to a specific commit/tag (and verify the correct default branch name).
| <img src="https://raw.githubusercontent.com/OpenRakis/Spice86/master/src/Spice86/Views/Assets/Spice86.ico" class="w-8 h-8 mr-3" alt="Spice86"> | |
| <svg class="w-8 h-8 mr-3 text-spice" viewBox="0 0 32 32" fill="none" xmlns="http://www.w3.org/2000/svg" role="img" aria-label="Spice86 icon"> | |
| <rect x="4" y="4" width="24" height="24" rx="6" fill="currentColor" fill-opacity="0.18" stroke="currentColor" stroke-width="2"/> | |
| <path d="M12 12H20M12 16H20M12 20H17" stroke="currentColor" stroke-width="2" stroke-linecap="round"/> | |
| <path d="M16 4V1M10 4V1M22 4V1M16 31V28M10 31V28M22 31V28M4 16H1M4 10H1M4 22H1M31 16H28M31 10H28M31 22H28" stroke="currentColor" stroke-width="2" stroke-linecap="round"/> | |
| </svg> |
Description of Changes
docs/index.html: Spice86 link card replaces the 🌶️ emoji with<img>pointing to the Spice86 MainWindow Avalonia asset (src/Spice86/Views/Assets/Spice86.icoviaraw.githubusercontent.com); DNPCS row removed from the Driver Remapping table.README.md: DNPCS row removed from the Driver Remapping table; inline prose updated to drop the DNPCS reference from the list of music drivers.Rationale behind Changes
PC Speaker music (DNPCS) does not exist — it was incorrectly listed alongside DNMID as a music driver. The Spice86 link was using a generic chili emoji; the actual application icon is the
.icoregistered on the AvaloniaMainWindow.Suggested Testing Steps
Open
docs/index.htmllocally and verify the Spice86 card shows the icon image. Confirm neither the HTML nor README driver tables mention DNPCS.