Fix .NET version: update all .NET 8 references to .NET 10#56
Fix .NET version: update all .NET 8 references to .NET 10#56maximilien-noal merged 1 commit intomainfrom
Conversation
Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/4ca9a027-5236-4e19-b520-cc39b72830c3 Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates project documentation to consistently reference the repo’s current target framework (.NET 10 / net10.0), reducing confusion when following build/run instructions.
Changes:
- Update README’s .NET SDK prerequisite, cross-platform blurb, and publish output path from .NET 8 → .NET 10.
- Update GitHub Pages site (
docs/index.html) to replace .NET 8 references (feature cards, prerequisites link, publish output path, contributing step) with .NET 10.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Replaces .NET 8 mentions with .NET 10, including the publish output path example. |
| docs/index.html | Replaces .NET 8 mentions with .NET 10 across the project website content and build instructions. |
| @@ -157,7 +157,7 @@ For the full experience with AdLib music and PCM sound effects: | |||
| ```bash | |||
| cd Cryogenic/src/Cryogenic | |||
| dotnet publish | |||
There was a problem hiding this comment.
The command uses dotnet publish without specifying a configuration, but the next line assumes the Release output path (bin/Release/...). By default, dotnet publish outputs to bin/Debug/... unless -c Release is provided. Update either the command to include -c Release or adjust the example path to match the default output.
| dotnet publish | |
| dotnet publish -c Release |
| @@ -400,7 +400,7 @@ <h3 class="text-xl font-bold mb-4 text-spice">Running with Audio</h3> | |||
| <div class="code-block rounded p-4 text-sm overflow-x-auto"> | |||
| <pre class="text-gray-300"><code>cd Cryogenic/src/Cryogenic | |||
| dotnet publish | |||
There was a problem hiding this comment.
The snippet runs dotnet publish but the following line uses the bin/Release/... path. Unless -c Release is specified, dotnet publish will typically place output under bin/Debug/.... Please align the command and the documented output path (add -c Release or update the path).
| dotnet publish | |
| dotnet publish -c Release |
Description of Changes
Replace all stale
.NET 8references with.NET 10acrossREADME.mdanddocs/index.html(GitHub Pages).dotnet publishoutput path (net8.0→net10.0)dotnet publishoutput path, Contributing setup stepRationale behind Changes
The project targets
net10.0(perCryogenic.csproj) but documentation consistently cited.NET 8, creating confusion for new contributors and users trying to follow the build/run instructions.Suggested Testing Steps
Visually verify the GitHub Pages site and README reflect
.NET 10in all SDK references, download links, and publish paths.