Update Cryogenic to Spice86 v12 NuGet by Copilot · Pull Request #54 · OpenRakis/Cryogenic

Copilot · 2026-04-03T22:16:07Z

Bumps the Spice86 NuGet dependency from 11.1.0 to 12.0.0 and migrates the codebase to the breaking API changes introduced in v12, which also requires upgrading the target framework from net8.0 to net10.0.

Changes

Cryogenic.csproj: TargetFramework → net10.0, Spice86 → 12.0.0
Overrides/Overrides.cs:
- using Spice86.Core.Emulator.Function.Dump → using Spice86.Core.Emulator.StateSerialization (MemoryDataExporter relocated)
- machine.Cpu.State.SegmentRegisters → machine.CpuState.SegmentRegisters (Machine.Cpu removed)
- DumpMemoryWithSuffix: constructor no longer accepts RecordedDataDirectory; DumpMemory(suffix) replaced with Write(path) via Path.Combine
Overrides/MT32DriverCode.cs: Cpu.Out16(0x330, AX) → Machine.IoPortDispatcher.WriteWord(0x330, AX) (Cpu removed from CSharpOverrideHelper)

Overrides/TimerCode.cs: Pit8254Counter / Timer.GetCounter() / counter properties removed in v12 (PitChannel is now internal). Replaced with direct PIT port I/O:

// Before (v11)
Pit8254Counter counter = timer.GetCounter(0);
counter.ReadWritePolicy = 0;
counter.Mode = 3;
counter.Bcd = false;
counter.Configure(valueToSet);

// After (v12)
Machine.Timer.WriteByte(0x43, 0x36); // ch0, both bytes, mode 3, binary
Machine.Timer.WriteByte(0x40, (byte)(valueToSet & 0xFF));
Machine.Timer.WriteByte(0x40, (byte)(valueToSet >> 8));

Rationale behind Changes

Spice86 v12 targets net10.0 exclusively and ships several breaking API removals: Machine.Cpu flattened into Machine.CpuState, Pit8254Counter internalized as PitChannel, MemoryDataExporter relocated and its constructor simplified, and CSharpOverrideHelper.Cpu removed in favour of Machine.IoPortDispatcher.

Suggested Testing Steps

Build with dotnet build from src/Cryogenic (must succeed with 0 errors). Runtime validation requires launching the game with dotnet run --Exe <path/to/DNCDPRG.EXE> --UseCodeOverride true and verifying normal game startup, MT-32 MIDI output, and clean shutdown (the timer override is exercised on quit).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

av-build-tel-api-v1.avaloniaui.net
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll "mcp-server-playwright" --viewport-size '1280, 720' --output-dircredential.helper (dns block)
- Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll get --global oslyn/bincore/VBCSCompiler credential.helpeiptables (dns block)
www.nuget.org
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

…, PitTimer Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

src/Cryogenic/Overrides/Overrides.cs

+        if (!Directory.Exists(dumpDirectory)) {
+            Directory.CreateDirectory(dumpDirectory);
+        }
+        string path = Path.Combine(dumpDirectory, $"spice86dumpMemoryDump{suffix}.bin");


In general, to avoid Path.Combine silently dropping earlier arguments when a later argument is absolute, use Path.Join when you are forming a path where all components are intended to be relative, or ensure the later components are sanitized so they cannot be absolute. Path.Join performs concatenation with the correct directory separators but does not treat an absolute later component as overriding earlier ones.

The best minimal fix here is to change the construction of path in DumpMemoryWithSuffix from Path.Combine to Path.Join. This keeps the existing behavior for all current relative suffixes and directory values, while removing the risk that a future absolute suffix might cause the directory to be ignored. Since System.IO.Path is in mscorlib/System.Private.CoreLib, no new imports or dependencies are required beyond what is already implied by the use of Path. The only edit needed is on the line where path is assigned.

Specifically:

In src/Cryogenic/Overrides/Overrides.cs, inside DumpMemoryWithSuffix, replace:

string path = Path.Combine(dumpDirectory, $"spice86dumpMemoryDump{suffix}.bin");
with:

string path = Path.Join(dumpDirectory, $"spice86dumpMemoryDump{suffix}.bin");

No other methods, imports, or definitions are needed.

Copilot

Pull request overview

Updates Cryogenic to work with the breaking changes in Spice86 v12 by upgrading the Spice86 NuGet dependency and adapting override code to the new VM/serialization/IO APIs, including a target framework bump required by the new package.

Changes:

Bump Spice86 from 11.1.0 to 12.0.0 and update TargetFramework to net10.0.
Migrate override code to Spice86 v12 API changes (CPU state access, memory dump exporter API, and port I/O APIs).
Replace PIT counter configuration API usage with direct PIT port I/O writes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`src/Cryogenic/Cryogenic.csproj`	Moves project to `net10.0` and updates Spice86 package reference to v12.
`src/Cryogenic/Overrides/Overrides.cs`	Updates CPU state access and adapts memory dump export to the new `MemoryDataExporter` API.
`src/Cryogenic/Overrides/MT32DriverCode.cs`	Uses `Machine.IoPortDispatcher` for MIDI port word writes (replacing removed `Cpu` helper).
`src/Cryogenic/Overrides/TimerCode.cs`	Replaces removed PIT counter abstraction with explicit PIT port programming sequence.

src/Cryogenic/Cryogenic.csproj

Initial plan

58b529d

Copilot AI assigned Copilot and maximilien-noal Apr 3, 2026

Copilot started work on behalf of maximilien-noal April 3, 2026 22:16 View session

Copilot AI and others added 3 commits April 3, 2026 22:23

Update Spice86 to v12: update TargetFramework and package version

3231449

Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

Fix Spice86 v12 API breaking changes: MemoryDataExporter, Machine.Cpu…

a9ef945

…, PitTimer Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

Use Path.Combine for cross-platform memory dump path construction

804bbc7

Agent-Logs-Url: https://github.com/OpenRakis/Cryogenic/sessions/20c8dc5c-cec2-4de7-8f31-0421e797651f Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>

github-code-quality bot found potential problems Apr 3, 2026

View reviewed changes

src/Cryogenic/Overrides/Overrides.cs Dismissed Show dismissed Hide dismissed

Copilot AI changed the title ~~[WIP] Update Cryogenic to spice86 v12 and ensure everything compiles~~ Update Cryogenic to Spice86 v12 NuGet Apr 3, 2026

Copilot finished work on behalf of maximilien-noal April 3, 2026 22:34

Copilot AI requested a review from maximilien-noal April 3, 2026 22:34

maximilien-noal marked this pull request as ready for review April 4, 2026 05:55

Copilot AI review requested due to automatic review settings April 4, 2026 05:55

Copilot started reviewing on behalf of maximilien-noal April 4, 2026 05:56 View session

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

Copilot AI reviewed Apr 4, 2026

View reviewed changes

src/Cryogenic/Cryogenic.csproj Show resolved Hide resolved

chore: update CI to dotnet 10 SDK

46a728c

maximilien-noal approved these changes Apr 4, 2026

View reviewed changes

maximilien-noal merged commit 5807f49 into main Apr 4, 2026
4 checks passed

maximilien-noal deleted the copilot/update-cryogenic-to-spice86-v12 branch April 4, 2026 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Cryogenic to Spice86 v12 NuGet#54

Update Cryogenic to Spice86 v12 NuGet#54
maximilien-noal merged 5 commits intomainfrom
copilot/update-cryogenic-to-spice86-v12

Copilot AI commented Apr 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Rationale behind Changes

Suggested Testing Steps

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 3, 2026 •

edited

Loading