Update RMC coasters to use RMC track sound#220
Merged
Conversation
Member
Author
|
Do the objects also need a version increase? Or should it be fine without it? |
Member
|
Yes, these objects need a version increase. The changes look fine to me, but I guess we’ll have to merge the sound effects and asset packs for them first? (Haven’t yet caught up with those, apart from Karst demonstrating them to me.) |
Member
Author
|
What could also work is merging this (after i have added the version increase), bumping the object release on here and on that PR. In the end that could also be done afterwards but this way you'd keep it all together. |
Member
|
That’s true, could you bump the version strings of these two objects then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to OpenRCT2#18312