Sticky the Misc scenery tab next to the All scenery tab#19536
Conversation
|
@trzejos If you could double-check this, that'd be great! |
|
I was thinking about this too, but decided not to bring it up, because I'm not sure if I like this change. Leaving the misc tab at the end of the scenery groups makes it so the rest of the items that don't fit have their own "scenery group", and having that listed beside the "all scenery" tab makes the misc tab feel kinda pointless. Not to mention it feels a tad cluttered having it attached to the all scenery tab. That's my personal opinion, though |
|
Maybe the tab sorting could just be overridden to ensure that the "Misc" tab (when present) is always the last one? That way, it's always relatively easy to find, but doesn't add any extra clutter, and it doesn't make the misc tab seem more special than it's supposed to be. |
|
@ocalhoun6 That is how it works normally. The problem comes when you have one too many tabs that overflow onto the next row, and suddenly the misc tab is the first item on the second row, where it isn't expected to be. |
trzejos
left a comment
There was a problem hiding this comment.
Looks good. I left a couple suggestions that you may or may not like, but either way this change makes sense.
|
This pull request is stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
Reminder to myself to rebase after 0.4.4 |
During some discussion with folks on the NE Discord server, it was suggested to anchor the Misc tab as we do for the All Scenery tab. As scenery row tabs are added, the Misc tab won't always be all the way on the right, so it can be hard to find at first. This will ensure it's always in the same place.
This change also has rows after the first one fully fill up with tabs, so there isn't a blank gap on the right, and each row does actually have 20 items in it.