Skip to content

Fix window scrollbar not able to navigate to the end of large lists#19515

Merged
ZehMatt merged 2 commits into
OpenRCT2:developfrom
ZehMatt:fix-large-list
Feb 28, 2023
Merged

Fix window scrollbar not able to navigate to the end of large lists#19515
ZehMatt merged 2 commits into
OpenRCT2:developfrom
ZehMatt:fix-large-list

Conversation

@ZehMatt

@ZehMatt ZehMatt commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

With 9000+ staff you could only scroll to half of the list while the scrollbar would sit at the end, this fixes the issue by using bigger integer types, the issue was actually an overflow.

Closes #592

@AaronVanGeffen

Copy link
Copy Markdown
Member

Nice find. Changelog entry?

@ZehMatt ZehMatt added this to the v0.4.4 milestone Feb 28, 2023
@Broxzier

Copy link
Copy Markdown
Member

Sounds like this fixes one of the oldest issues: #592

@ZehMatt

ZehMatt commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

I was actually looking for an existing issue but I couldn't find it, ill change the entry. Thanks.

@ocalhoun6

Copy link
Copy Markdown
Contributor

Maybe the changelog entry should say (original bug) on it? Since #592 was present in vanilla.

@ZehMatt

ZehMatt commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

Considering the original couldn't have that many things in a list its probably OpenRCT2 specific, not exactly a bug either.

@Umdlye

Umdlye commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

I've tested this in the object selection window with a small scenery list of ~9000+ objects and it works as expected :) Scenery hoarders rejoice!

@ZehMatt ZehMatt merged commit d18de99 into OpenRCT2:develop Feb 28, 2023
@ZehMatt ZehMatt deleted the fix-large-list branch February 28, 2023 20:34
@Gymnasiast

Gymnasiast commented Feb 28, 2023

Copy link
Copy Markdown
Member

Considering the original couldn't have that many things in a list its probably OpenRCT2 specific, not exactly a bug either.

Not for staff, but it did occur with the object list in RCT2, for which vanilla had no hard limit.

I've tested this in the object selection window with a small scenery list of ~9000+ objects and it works as expected :) Scenery hoarders rejoice!

Lovely, I was already wondering whether this would also fix that bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Very long object list cannot be scrolled

7 participants