Fix #14635: Show more scenery tab groups in rows#19373
Conversation
|
why is this a draft? btw, ammend your commit message to meet formatting in git. Might be good to squash as well |
|
thamk you for fixing this |
9feec02 to
2036d13
Compare
Legotown55
left a comment
There was a problem hiding this comment.
hi i have been testing this fix and it works fine se whn will this fix be merged
|
@fidwell could you provide a few screenshots of this and maybe a video if you have the time. |
|
@duncanspumpkin Here are some screenshots made with the build this PR generated: An empty scenario with no scenery selected at all (no change): Loopy Landscapes scenery only (no change): |
|
In Locomotion the tabs rotate when you click on one so that the one clicked is always the first one. Would that be annoying? Its more for future work tbh. |
|
I briefly thought about that... personally, I hate that kind of design. I think it's really bad UX when your controls start moving on their own, and with 3 or more rows it isn't immediately clear where they went. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
It would be good to somehow highlight the active tab, by making it a different color or outlining it or something, but that could be left to a different PR. |






Fixes #14635. This PR does not include the horizontal offsets discussed in the issue. I figured it might be better to keep this PR smaller.