Skip to content

Fix #14635: Show more scenery tab groups in rows#19373

Merged
duncanspumpkin merged 1 commit into
OpenRCT2:developfrom
fidwell:scenery-tab-rows
Feb 14, 2023
Merged

Fix #14635: Show more scenery tab groups in rows#19373
duncanspumpkin merged 1 commit into
OpenRCT2:developfrom
fidwell:scenery-tab-rows

Conversation

@fidwell

@fidwell fidwell commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

Fixes #14635. This PR does not include the horizontal offsets discussed in the issue. I figured it might be better to keep this PR smaller.

@fidwell fidwell changed the title Show more scenery tab groups in rows Fix #14635: Show more scenery tab groups in rows Feb 12, 2023
@733737

733737 commented Feb 12, 2023

Copy link
Copy Markdown
Contributor

why is this a draft? btw, ammend your commit message to meet formatting in git. Might be good to squash as well

@Legotown55

Copy link
Copy Markdown

thamk you for fixing this

@fidwell fidwell marked this pull request as ready for review February 12, 2023 14:57

@Legotown55 Legotown55 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi i have been testing this fix and it works fine se whn will this fix be merged

@duncanspumpkin

Copy link
Copy Markdown
Contributor

@fidwell could you provide a few screenshots of this and maybe a video if you have the time.

@fidwell

fidwell commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

@duncanspumpkin Here are some screenshots made with the build this PR generated:

Forest Frontiers (no change):
image

An empty scenario with no scenery selected at all (no change):
image

Loopy Landscapes scenery only (no change):
image

RCT2, expansion, and official scenery:
image

All my custom groups selected (129 total):
image

@duncanspumpkin

Copy link
Copy Markdown
Contributor

In Locomotion the tabs rotate when you click on one so that the one clicked is always the first one. Would that be annoying? Its more for future work tbh.

@Broxzier

Copy link
Copy Markdown
Member

On Windows, the row with the active tab is always moved to the bottom, but then all rows need to span the full width for it to look right.

image

@fidwell

fidwell commented Feb 14, 2023

Copy link
Copy Markdown
Contributor Author

I briefly thought about that... personally, I hate that kind of design. I think it's really bad UX when your controls start moving on their own, and with 3 or more rows it isn't immediately clear where they went.

@Legotown55

This comment was marked as off-topic.

@Legotown55

This comment was marked as off-topic.

@duncanspumpkin duncanspumpkin merged commit ef730aa into OpenRCT2:develop Feb 14, 2023
@duncanspumpkin duncanspumpkin added this to the v0.4.4 milestone Feb 14, 2023
@ocalhoun6

Copy link
Copy Markdown
Contributor

It would be good to somehow highlight the active tab, by making it a different color or outlining it or something, but that could be left to a different PR.

@fidwell fidwell deleted the scenery-tab-rows branch February 15, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scenery window cannot display more than 32 tabs.

6 participants