Skip to content

Attempt to find the reason for #19353#19354

Closed
Broxzier wants to merge 1 commit into
OpenRCT2:developfrom
Broxzier:bugfix/dependency-download-error
Closed

Attempt to find the reason for #19353#19354
Broxzier wants to merge 1 commit into
OpenRCT2:developfrom
Broxzier:bugfix/dependency-download-error

Conversation

@Broxzier

Copy link
Copy Markdown
Member

This initial purpose of this PR is to get some more information on why the download fails.

@Broxzier

Copy link
Copy Markdown
Member Author

Reran the Windows builds a couple times now, but of course they finish without errors each time.

I'm pretty sure that the error happens in client.DownloadFile. A couple posts online suggest to force TLS 1.2, though this should be something the OS handles. I'm not sure if this is the best idea, but we could try setting it and see if it works.

ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12

@github-actions

Copy link
Copy Markdown

This pull request is stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@Broxzier

Copy link
Copy Markdown
Member Author

Closing this, as I haven't seen this happen anymore in recent builds. It may have been an issue on GitHub itself.

@Broxzier Broxzier closed this Feb 28, 2023
@Broxzier Broxzier deleted the bugfix/dependency-download-error branch February 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant