Skip to content

fix listview type mistakes in .d.ts introduced by #18428#19057

Merged
tupaschoal merged 1 commit into
OpenRCT2:developfrom
Sadret:dts-listview-fix
Jan 6, 2023
Merged

fix listview type mistakes in .d.ts introduced by #18428#19057
tupaschoal merged 1 commit into
OpenRCT2:developfrom
Sadret:dts-listview-fix

Conversation

@Sadret

@Sadret Sadret commented Jan 5, 2023

Copy link
Copy Markdown
Contributor
  • Although the type of ListView.items will always be reported as string[][], it is still possible to write to it using string or ListViewItemSeperator per row.
  • ListView.selectedCell == null indicates that no cell is selected.

@Sadret Sadret changed the title fix type mistake introduced by #18428 fix listview type mistakes in .d.ts introduced by #18428 Jan 5, 2023

@tupaschoal tupaschoal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it require a plugin version bump?

@IntelOrca

Copy link
Copy Markdown
Contributor

@tupaschoal changing the d.ts does not affect the game.

@tupaschoal tupaschoal merged commit 8495dbf into OpenRCT2:develop Jan 6, 2023
@Sadret Sadret deleted the dts-listview-fix branch January 6, 2023 17:06
@tupaschoal tupaschoal added this to the v0.4.4 milestone Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants