Fix duplicate RGB colours in palette#18299
Conversation
|
I would like larger contrast with the unique colors but LGTM otherwise. |
|
You can create a PR against my branch if you like. |
9ff9513 to
99851fa
Compare
a551268 to
e7c704c
Compare
|
Well thats just pointed out that a good chunk of the tests aren't being run on cmake builds. |
|
@duncanspumpkin Seems like it, yes. If you have time, could you perhaps take a look at my branch and update the tests? As far as I can see, the logo looks exactly the same, but due to the nature of the PR (deduplicating indices) it’s inevitable that some pixels now have a different palette index than they had before. |
|
This pull request is stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
Keeps this open please. |
|
This pull request is stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
will this interfere with kyphii's pr? |
|
no |
|
Can you rebase this? |
e7c704c to
4f61d48
Compare
Would like confirmation from @spacek531 that this is indeed sufficient, and that I didn’t miss any of the duplicates (water or otherwise).