Skip to content

Fix #18087: Bank balance clamped to a 32-bit integer every transaction#18120

Merged
Gymnasiast merged 1 commit into
OpenRCT2:developfrom
Gymnasiast:fix/18087
Sep 28, 2022
Merged

Fix #18087: Bank balance clamped to a 32-bit integer every transaction#18120
Gymnasiast merged 1 commit into
OpenRCT2:developfrom
Gymnasiast:fix/18087

Conversation

@Gymnasiast

Copy link
Copy Markdown
Member

No description provided.

@Gymnasiast

Copy link
Copy Markdown
Member Author

This fixes the issue itself, although there is still a lot of code that assumes all money is in 32-bit. But that’s a big refactor and probably best left for another time.

@Gymnasiast Gymnasiast added the changelog This issue/PR deserves a changelog entry. label Sep 27, 2022
@IntelOrca IntelOrca added the network version Network version needs updating - double check before merging! label Sep 27, 2022
@Gymnasiast Gymnasiast force-pushed the fix/18087 branch 2 times, most recently from d1b8e2c to 99c0783 Compare September 27, 2022 19:33
@Gymnasiast Gymnasiast merged commit a0dd6a3 into OpenRCT2:develop Sep 28, 2022
@Gymnasiast Gymnasiast deleted the fix/18087 branch September 28, 2022 10:20
@tupaschoal tupaschoal added this to the v0.4.2 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog This issue/PR deserves a changelog entry. network version Network version needs updating - double check before merging!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bank balance is casted / clamped to a 32-bit signed integer when changed via a game action

3 participants