refactor Park::CalculateSuggestedMaxGuests#17873
Merged
Merged
Conversation
| uint32_t suggestedMaxGuests = 0; | ||
| uint32_t difficultGenerationBonus = 0; | ||
|
|
||
| // TODO combine the two ride loops |
Contributor
There was a problem hiding this comment.
I don't think it makes sense to combine the two loops the old code was easier to read imho.
Contributor
|
This will need a network version bump. |
Gymnasiast
reviewed
Sep 3, 2022
Gymnasiast
approved these changes
Sep 3, 2022
4b42a0b to
eea69c0
Compare
Member
|
Next time, please use separate commits for the fix and for the refactor. |
Contributor
Author
Okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines two loops into one.
Also fixes #17865. (With difficult guest generation, tested but unopened rides still contribute to the guest cap.)