Clean up palette import#16601
Merged
Merged
Conversation
c85cd79 to
01db530
Compare
01db530 to
4d6f7e3
Compare
ZehMatt
reviewed
Feb 7, 2022
Comment on lines
+47
to
+51
| enum class PALETTE : uint8_t | ||
| { | ||
| OPENRCT2, | ||
| KEEP_INDICES, | ||
| }; |
Contributor
There was a problem hiding this comment.
This is not our coding style, we usually do
enum class MyEnum : uint32_t
{
First = 1,
Second,
Third,
Count,
}
Member
Author
There was a problem hiding this comment.
I will address that in another PR and also do the other enums for the image importer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up palette handling in sprite import and makes it much easier to add more (especially the green one that every other tool uses).