Block brake improvements#13838
Closed
spacek531 wants to merge 22 commits into
Closed
Conversation
ce73d5b to
fc3ca4f
Compare
Collaborator
Author
|
Will also solve this duplicate issue: |
182baad to
d641924
Compare
d641924 to
d56f430
Compare
Collaborator
Author
4 tasks
8084c09 to
f8eaa01
Compare
Gymnasiast
reviewed
Jan 30, 2021
8fc89ee to
5f28da4
Compare
Collaborator
Author
|
|
0b63cd9 to
8fc89ee
Compare
506b03e to
0a25b81
Compare
spacek531
commented
Aug 31, 2021
bad4213 to
54a4e84
Compare
54a4e84 to
4cc2c31
Compare
5021d41 to
3a6545a
Compare
mostly completed implementation set block brake speed to 4 when building fix import/export comments remove unecessary variable satisfy warnings fix fallthrough unify brake/block brake closed status part 1 rename action functions fix import and export and others fix desync fix formatting remove seat rotation from block brakes update brake status when changing brake speed fix format set bbrake speed on TD6 import fix rebase error revert unnecessary enum changes move functions and declarations to better places move open brake condition into velocity condition move Track.cpp functions to a better place revert polarity of SetBrakeClosed fix rebase error revert changes to strings add changelog entry add tile inspector strings remove formatting from STR_6319-STR_6321 add strings for block brake construction change function to get any sequence use safer thingy fix groupbox text for block brakes only open linked brakes in block section mode revert change to stringid.h whitespace
3a6545a to
4112256
Compare
c6678c9 to
d2e457a
Compare
Member
|
Is this ready for review? |
Collaborator
Author
|
There's one or two vestigial pieces that need to be removed, but I think it's ready. |
24fe27a to
e490be7
Compare
spacek531
commented
Feb 16, 2022
spacek531
commented
Feb 16, 2022
Contributor
|
I'm closing this PR due to inactivity, feel free to reopen when you continue working on it. |
Collaborator
Author
|
I have rebased and addressed the outstanding self-comments. I would reopen this PR but since I am not a maintainer, I am not able to. Would someone please re-open this PR? |
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I started on this branch because at the time I didn't know about the old PR. @X123M3-256 told me about the old PRs #7737 and #11649 and that there were some larger technical issues, but he didn't remember what they were and the old PR does not say what they are.
OpenRCT2 side, everything is unified to the block brake flag indicating that brakes are active and the absence meaning they are open.
SV6 side, the polarity is inverted for brakes, since they normally serialize with the flag as false.
TD6 side, block brake speed is not exported nor imported. It is set to the minimum on loading.
NSF side, a version bump is required and behavior to normalize old save format brake flags.