Implement #13384: Expose all TileElement data to plugin API#13536
Merged
Conversation
Gymnasiast
reviewed
Dec 10, 2020
Gymnasiast
reviewed
Dec 13, 2020
Gymnasiast
approved these changes
Dec 17, 2020
Gymnasiast
left a comment
Member
There was a problem hiding this comment.
LGTM, but would like either @IntelOrca or @duncanspumpkin to review it as well.
Merged
duncanspumpkin
approved these changes
Jan 3, 2021
duncanspumpkin
left a comment
Contributor
There was a problem hiding this comment.
Don't forget to increment the api version
Contributor
Author
I did, twice. Now a third time, I guess. |
Contributor
Author
|
Changed |
Contributor
|
@Sadret for future what I do is wait until all of the reviews are in and no further changes are being asked and then bump the network/plugin version. Means you don't have to do it as many times. Doesn't always work out like that though :(. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following fields:
TileElement.isGhost
TileElement.baseZ (= baseHeight * 8)
TileElement.clearanceZ (= clearanceHeight * 8)
Footpath.edges
Footpath.corners
Track.mazeEntry
Track.colourScheme
Track.seatRotation
Track.brakeBoosterSpeed ( = stored value * 2)
Track.isInverted
Track.hasCableLift
Wall.slope
Wall.primaryColour
Wall.secondaryColour
Wall.tertiaryColour
Wall.bannerIndex
LargeScenery.bannerIndex
LargeScenery.sequence
Banner.bannerIndex
Banner.direction
Removes the following fields:
Footpath.edgesAndCorners (replaced by Footpath.edges and Footpath.corners)
Footpath.railings (unused)
Footpath.direction (unused)
Changes to openrct2.d.ts
Other changes: