More game action visitors added (all Park, Staff, Guest, Banner)#12933
More game action visitors added (all Park, Staff, Guest, Banner)#12933tombomp wants to merge 8 commits into
Conversation
|
|
||
| void AcceptParameters(GameActionParameterVisitor & visitor) override | ||
| { | ||
| visitor.Visit("type", _type); |
There was a problem hiding this comment.
Hmm what would plugin users pass for this?
| { | ||
| } | ||
|
|
||
| void AcceptParameters(GameActionParameterVisitor & visitor) override |
There was a problem hiding this comment.
Do not expose this action it should never be used by plugins it is only used by TrackDesigns.
| { | ||
| } | ||
|
|
||
| void AcceptParameters(GameActionParameterVisitor & visitor) override |
There was a problem hiding this comment.
Debatable if this is safe to perform from a plugin. Pretty sure this will unload the plugin.
|
|
||
| void AcceptParameters(GameActionParameterVisitor & visitor) override | ||
| { | ||
| visitor.Visit("parameter", _parameter); |
There was a problem hiding this comment.
this action does not follow the order of other commands. value should be parameter and parameter should be some sort of type
| void AcceptParameters(GameActionParameterVisitor & visitor) override | ||
| { | ||
| visitor.Visit("setting", _setting); | ||
| visitor.Visit("value", _value); |
|
There are a few here that I do not think should be usable by plugins and others that are dangerous to use. A lot of the parameters need some careful thought on their names as we should standardise it as much as possible to prevent issues with later renaming. |
|
@tombomp Are you still working on this? |
Ah sorry real life got in the way but I'm not, sorry. I'll close it, sorry for not finishing it. Some of these have been added by other PRs anyway and the rest has enough issues someone else should probably start from scratch re naming and which ones are worth exposing. Sorry once again. |
|
No need to be sorry, it happens. Thanks for letting us know and feel free to come back when you're freer :) |
There's a lot of files changed here but it's all pretty rote stuff. There's still a few involving a MapRange that don't have a visitor, this is just all the simple ones.
With the names if I noticed an already existing similar one was using a name different to the variable I used that, otherwise I mostly just copied the variable name. Obviously any better naming suggestions are welcome.