Skip to content

Refactor screen state swapping#10180

Closed
ZehMatt wants to merge 8 commits into
OpenRCT2:developfrom
ZehMatt:refactor/screenstates
Closed

Refactor screen state swapping#10180
ZehMatt wants to merge 8 commits into
OpenRCT2:developfrom
ZehMatt:refactor/screenstates

Conversation

@ZehMatt

@ZehMatt ZehMatt commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

Some initial work towards having multiple screen states. This will allow to have at some point loading screens that will do all the things in the background and simply swap the screen state after it has loaded all the required things, its still pretty raw and I would like to get some feedback like if we want to go this route.

@ZehMatt

ZehMatt commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

Also I was wondering if we maybe should call this 'Scene' instead of 'Screen', so we get TitleScene, GameScene, LoadingScene etc.

@AaronVanGeffen

Copy link
Copy Markdown
Member

This sound very similar to the (ambitious) goals the initial GameState PR #5979 set out with. We never got quite that far. I haven't looked at the code in detail yet, but good to see this resurface.

Scene sounds like a better name to me as well.

Comment thread src/openrct2/Context.cpp Outdated
Comment thread src/openrct2/screens/game/GameScreen.cpp Outdated

@tjwrona tjwrona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't officially know enough about the program structure at this point to feel comfortable approving/disapproving this review, but I've made a couple comments.

Comment thread src/openrct2/Context.cpp Outdated
Comment thread src/openrct2/screens/game/GameScreen.cpp Outdated
@Gymnasiast Gymnasiast removed the request for review from rwjuk November 4, 2019 21:20

@tjwrona tjwrona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but I don't have a problem with it. Why change the name from "screen" to "scene"? Is it because scene is a more generic term and a scene may not necessarily correspond to a screen?

@duncanspumpkin duncanspumpkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've not played with it myself.

@tupaschoal tupaschoal modified the milestone: After v0.2.6 Apr 13, 2020
@tupaschoal tupaschoal modified the milestone: v0.2.7 Consideration Apr 17, 2020
@Gymnasiast Gymnasiast marked this pull request as draft July 9, 2020 13:03
@AaronVanGeffen AaronVanGeffen added the pending rebase PR needs to be rebased. label Aug 26, 2020
@ZehMatt

ZehMatt commented Aug 21, 2021

Copy link
Copy Markdown
Contributor Author

This needs a fresh start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending rebase PR needs to be rebased.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants