Fix Mac Bundle Generation#3629
Merged
duncanspumpkin merged 6 commits intoOpenLoco:masterfrom Feb 3, 2026
Merged
Conversation
Member
|
Objects are bundled correctly now: 
Still needs fiddling with 
Worth adding a changelog entry for the fix? |
AaronVanGeffen
approved these changes
Feb 3, 2026
58afec6 to
549d1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the MacOS bundle generation so that it contains all of the correct files (including objects).
I'll need to further rework things to unify across the various platforms but this will at least improve the main generation for now.
It will still be stripping the attributes on upload but that can be solved separately.