Fix missing string on can't remove vehicle error#3603
Merged
duncanspumpkin merged 3 commits intoOpenLoco:masterfrom Jan 7, 2026
Merged
Fix missing string on can't remove vehicle error#3603duncanspumpkin merged 3 commits intoOpenLoco:masterfrom
duncanspumpkin merged 3 commits intoOpenLoco:masterfrom
Conversation
Contributor
Author
|
Additionally I think #2627 should already be closed as fixed as I didn't encounter that bug. With disable breakdowns on, the vehicle eventually repaired. |
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add a changelog entry?
Contributor
Author
|
@AaronVanGeffen Do you know which issue I should be linking to in the changelog or should I just reference this PR? #2627 is a different bug, and #2803 kind of references it but was closed as a duplicate of the previously mentioned one. |
Contributor
Author
|
I'll just link to this PR for now, let me know if you want it different |
Contributor
|
@ethan-xd You link the PR that had the code change being merged. So you'd link this one, 3603 |
duncanspumpkin
approved these changes
Jan 7, 2026
Contributor
duncanspumpkin
left a comment
There was a problem hiding this comment.
Checked against the assembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format arguments were skipping the wrong amount.
Before
After