Update CMake presets and readme#3523
Merged
AaronVanGeffen merged 17 commits intoOpenLoco:masterfrom Dec 10, 2025
Merged
Conversation
Member
There was a problem hiding this comment.
Not sure about referring to 32-bit builds as x86-32. Essentially the CPU architecture no longer matters, right? I mean that we could make e.g. 32-bit ARM builds as well. Maybe just call it 32bit?
Left a few in-line comments as well (minor rephrasing as well as a question).
Co-authored-by: Aaron van Geffen <aaron@aaronweb.net>
Co-authored-by: Aaron van Geffen <aaron@aaronweb.net>
b6cd1bf to
a60671f
Compare
AaronVanGeffen
approved these changes
Dec 10, 2025
ZehMatt
approved these changes
Dec 10, 2025
Contributor
|
One pending check seems stuck, I restarted the jobs but it's still there, so lets ignore that. |
Member
|
Yeah the job has been renamed. It's showing up as we set it up as a requirement for merging. We'll just have to drop the merge requirement and add the new ones after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the presets and readme to hopefully simplify things.
In general if developing you would now use either the windows preset or the posix preset.
There is also the following presets: windows-x86-32-ci, linux-x86-32-ci, mingw32, linux-vcpkg-static, macos-vcpkg-static. Possibly need to add a windows-ci preset which is just windows with the Ninja generator for x64 builds. I've also update the readme a bit.