Rework remaining legacy config into modern config#3281
Merged
AaronVanGeffen merged 24 commits intoOpenLoco:masterfrom Oct 14, 2025
Merged
Rework remaining legacy config into modern config#3281AaronVanGeffen merged 24 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 24 commits intoOpenLoco:masterfrom
Conversation
e3edea4 to
88b15ff
Compare
dd5a610 to
83fb520
Compare
|
|
||
| sub_431695(var_F253A0); | ||
|
|
||
| if (Config::get().old.countdown != 0xFF) |
Contributor
There was a problem hiding this comment.
This is interesting is this saying that it would save the config after 255 ticks?
Member
Author
There was a problem hiding this comment.
Yeah, I'm thinking it's a measure to set the initial config file? The property is initiased to 0 so this would only run on first run, I think.
LeeSpork
reviewed
Oct 2, 2025
73cec01 to
c4c62ce
Compare
AaronVanGeffen
commented
Oct 13, 2025
duncanspumpkin
approved these changes
Oct 13, 2025
c4c62ce to
ee156e8
Compare
This was referenced Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the remaining legacy config fields into the modern config struct. This means we can now purge the legacy config entirely.
Currently, this is all done in one PR. Let me know if it would be better to split this up.