Remove globals from scenario index#3276
Merged
AaronVanGeffen merged 3 commits intoOpenLoco:masterfrom Oct 14, 2025
Merged
Conversation
AaronVanGeffen
requested changes
Oct 13, 2025
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Building the scenario index seems to be working fine, but something is going wrong writing it to file. Other than the magic numbers at the beginning, scores.dat is all zeros. Oddly enough, the file seems to be at the expected length, though (same size as the file I had before).
ZehMatt
reviewed
Oct 13, 2025
478bc35 to
3a63f91
Compare
Contributor
Author
|
Okay think this works now |
ZehMatt
approved these changes
Oct 13, 2025
Contributor
ZehMatt
left a comment
There was a problem hiding this comment.
No objections on the code, haven't tested this.
3a63f91 to
de39c3b
Compare
052761d to
c440efc
Compare
de39c3b to
2f807a7
Compare
AaronVanGeffen
approved these changes
Oct 14, 2025
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Looks like it's all working correctly now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little bit of rework so should test this a little make sure i haven't broken anything.
Fix #2797