Changes scrollbar types to 32 bits to account for very large scroll content sizes#3216
Merged
LeftofZen merged 5 commits intoOpenLoco:masterfrom Aug 20, 2025
Merged
Conversation
Contributor
Author
|
Closes #1682 |
ZehMatt
reviewed
Aug 19, 2025
src/OpenLoco/src/Ui/ScrollFlags.hpp
Outdated
Comment on lines
+51
to
+56
| uint32_t hThumbLeft; // 0x06 | ||
| uint32_t hThumbRight; // 0x08 | ||
| int32_t contentOffsetY; // 0x0A | ||
| int32_t contentHeight; // 0x0C | ||
| uint32_t vThumbTop; // 0x0E | ||
| uint32_t vThumbBottom; // 0x10 |
Contributor
There was a problem hiding this comment.
Just make them all int32_t, the amount of static_casts would be vastly reduced. You probably have to adjust the signature of getScrollSize as well.
Contributor
Author
There was a problem hiding this comment.
fair point, i've made the changes
7d44cdf to
7c447b9
Compare
7c447b9 to
86cdcc4
Compare
ZehMatt
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes scrollbar types to 32 bits to account for very large scroll content sizes. Changing the height is necessary, but changing the width isn't that necessary since there are no large-horizontally-scrolling windows in the game currently