Fix minimap not being centred correctly and refactor for readability#3190
Merged
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom Aug 8, 2025
Merged
Fix minimap not being centred correctly and refactor for readability#3190AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
Conversation
ZehMatt
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started out as an attempt to figuring out why the map window's initial scroll position overshoots.
The actual bug ended up not having to do with the logic in
centerOnViewPoint, but due to reading variables from the template widgets instead of the window's actual ones. (See the final commit 318c8bf for the actual fix.)Counterpart in our sister project: OpenRCT2/OpenRCT2#24905
Before
After