Removing savedView.isEmpty() is not the right approach. The check is necessary to see if an entity is being followed!

What's going wrong here is that SavedView::entityId used to share its memory with mapX. As of #3119 (June 2025) it no longer does, leading to the entityId property being ignored somewhere down the line. Reverting fc8eac2 fixes the issue, but that doesn't sit right with me either.

@ZehMatt, could you look into this?

Removing savedView.isEmpty() is not the right approach. The check is necessary to see if an entity is being followed!

What's going wrong here is that SavedView::entityId used to share its memory with mapX. As of #3119 (June 2025) it no longer does, leading to the entityId property being ignored somewhere down the line. Reverting fc8eac2 fixes the issue, but that doesn't sit right with me either.

@ZehMatt, could you look into this?

I've had a look and this does make sense as this is for the main window which doesn't have a saved view so the saved view is always empty. The being followed state is being stored in viewportConfigurations[0].viewportTargetSprite which is unlike all the other windows which store it in the saved view. The reason reverting fc8eac2 works is that before that we didn't initialise the saved view to empty we initialised it to 0 which is a valid value. So either we remove all the isEmpty checks that previously were reading invalid memory or we setup the saved view to actually store the entity. Why we have two things that store the entity is another question.

Removing savedView.isEmpty() is not the right approach. The check is necessary to see if an entity is being followed!
What's going wrong here is that SavedView::entityId used to share its memory with mapX. As of #3119 (June 2025) it no longer does, leading to the entityId property being ignored somewhere down the line. Reverting fc8eac2 fixes the issue, but that doesn't sit right with me either.
@ZehMatt, could you look into this?

I've had a look and this does make sense as this is for the main window which doesn't have a saved view so the saved view is always empty. The being followed state is being stored in viewportConfigurations[0].viewportTargetSprite which is unlike all the other windows which store it in the saved view. The reason reverting fc8eac2 works is that before that we didn't initialise the saved view to empty we initialised it to 0 which is a valid value. So either we remove all the isEmpty checks that previously were reading invalid memory or we setup the saved view to actually store the entity. Why we have two things that store the entity is another question.

So i think the main issue is that the main window doesn't operate like all the others and the viewport focus on main code hasn't accounted for the fact it doesn't work the same. Either we should make main work like all the other windows or we should remove these checks and rename the functions to make it clear they are only for use with main.

Here is my proposed patch that moves the function to make it clear its for working on main only
moveFunctions.patch

I've applied my suggested change of movign the functions. Think this is now good to go.