Skip to content

Fix mouse getting stuck on edges of monitor when right mouse dragging scrollviews#3020

Merged
duncanspumpkin merged 2 commits intoOpenLoco:masterfrom
LeeSpork:engooden-mouse-input
Aug 9, 2025
Merged

Fix mouse getting stuck on edges of monitor when right mouse dragging scrollviews#3020
duncanspumpkin merged 2 commits intoOpenLoco:masterfrom
LeeSpork:engooden-mouse-input

Conversation

@LeeSpork
Copy link
Copy Markdown
Contributor

@LeeSpork LeeSpork commented Mar 15, 2025

Mainly to change stateScrollRight() to use getNextDragOffset() (like stateViewportRight() already does) instead of the x, y from handleMouse().

Also a couple new unrelated code comments and a minor code style change in the same file.

@LeeSpork LeeSpork changed the title Fix #3019 and other minor MouseInput.cpp changes Fix mouse getting stuck on edges of monitor when right mouse dragging scrollviews Aug 7, 2025
@duncanspumpkin
Copy link
Copy Markdown
Contributor

I'm not able to reproduce the original issue but perhaps its machine specific? Could you rebase/merge in master.

@LeeSpork LeeSpork force-pushed the engooden-mouse-input branch from fbf3188 to 3da6fab Compare August 8, 2025 11:36
@LeeSpork
Copy link
Copy Markdown
Contributor Author

LeeSpork commented Aug 8, 2025

  • Rebased
  • Made sure it still works

@duncanspumpkin duncanspumpkin merged commit 548c97a into OpenLoco:master Aug 9, 2025
10 checks passed
@AaronVanGeffen AaronVanGeffen added this to the v25.07+ milestone Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mouse gets stuck on edges of monitor when right mouse dragging scrollview widgets

4 participants