Merged
Conversation
Merged
Contributor
|
Are we confident nothing was using the wrap strings writing to the current font global? I think its fine can't think why you would rely on that. |
Contributor
Author
I think it should be fine, when it uses the stateless version to get string width it has to provide the font and when its used for the draw functions it typically sets it. I was playing a bit and didn't really notice any oddities, also in case its somewhere wrong it will be no big deal to address given we can look at just what window it is. |
e8ae315 to
4300ee5
Compare
duncanspumpkin
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.