Different text input length limits for different fields#1651
Merged
AaronVanGeffen merged 7 commits intoOpenLoco:masterfrom Sep 27, 2022
Merged
Different text input length limits for different fields#1651AaronVanGeffen merged 7 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 7 commits intoOpenLoco:masterfrom
Conversation
…Changes in TextInput class
AaronVanGeffen
approved these changes
Sep 27, 2022
This was referenced Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR that I declared to make. #1646 (comment)
This PR basicly makes text input to not accept more characters than maximal length of the string that it's setting. I'm not sure about the limit for "enter_host_address", so i assigned it with 15 (length of the longest possible IPv4 addess). "chat_title" and "title_industry_name" are mapped with 15 by now, like every other "title". I haven't checked limit for "chat_title" yet. Text input window don't open when I double-click the caption in the industry window (idk if it's a bug).