fix: session-abort race & strip __PYVENV_LAUNCHER__ for macOS#75
Merged
fix: session-abort race & strip __PYVENV_LAUNCHER__ for macOS#75
Conversation
…letion message Move removeSession/delete calls after ws.send() in claude-sdk, gemini-cli, and cursor-cli so abort requests arriving during the completion window still find the session and return success instead of a misleading error.
On macOS, when a Python framework build (e.g. system Python 3.8) spawns a subprocess that uses a different Python version (e.g. uv-installed 3.13), the inherited __PYVENV_LAUNCHER__ variable causes the child interpreter to look for its stdlib in the wrong prefix, failing with "No module named 'encodings'". Strip this variable in all three call sites: the Node.js spawn layer (news.js) and both Python search scripts (search_xiaohongshu.py, search_x.py).
Collaborator
|
LGTM, fixed a dual definition issue that block backend server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeSession/activeXxxSessions.deleteuntil after the completion event is sent to the client, preventing a race where an abort request arrives between session cleanup and the completion message (Claude, Cursor, Gemini).__PYVENV_LAUNCHER__fix: Strip__PYVENV_LAUNCHER__from the environment when spawning Python CLI subprocesses (xhs,twitter) on macOS so uv-installed tools find the correct stdlib instead of erroring with "No module named 'encodings'".Test plan
encodingsimport error