feat: safer project trash flow and faster project refresh#68
Merged
Zhang-Henry merged 4 commits intomainfrom Mar 22, 2026
Merged
feat: safer project trash flow and faster project refresh#68Zhang-Henry merged 4 commits intomainfrom
Zhang-Henry merged 4 commits intomainfrom
Conversation
Collaborator
Code Review严重 Bug 1 — 升级后所有项目消失
现有的 需要:添加首次运行时从文件系统扫描并填充 严重 Bug 2 — 永久删除可能误删其他项目
await fs.rm(trashMeta.originalPath, { recursive: true, force: true });如果用户 trash 了项目 A(路径 建议:删除前检查目录内容是否与原项目匹配(如比较某个标识文件),或至少二次确认。 严重 Bug 3 — logical delete 标记无限增长
中等问题
小问题
|
Collaborator
Author
|
Thanks @Zhang-Henry for your comprehensive review! I already fixed them with a new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer Fixes
_deletedProjectsmetadata instead of leaking deaddeletedmarkersTesting
Context