fix(chat): prevent right sidebar overflow in narrow windows#156
Merged
Zhang-Henry merged 1 commit intomainfrom Apr 11, 2026
Merged
fix(chat): prevent right sidebar overflow in narrow windows#156Zhang-Henry merged 1 commit intomainfrom
Zhang-Henry merged 1 commit intomainfrom
Conversation
Contributor
|
I reviewed the sidebar overflow fix and don't see any blocking issues in the implementation. The change makes sense end-to-end: the expanded sidebar can now shrink within the flex layout, the tab strip falls back to horizontal scrolling instead of compressing the buttons, the collapse control is protected from shrinking away, and drag-resize is capped by the actual available container width rather than only the global max width. The main remaining risk is UI regression coverage rather than code correctness. I'd recommend manually verifying a few edge cases before merge:
From the code side, this looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex-shrink-0from expanded sidebar so it shrinks naturally within the flex container instead of overflowing the viewportflex-shrink-0Test plan