fix: resolve Windows desktop build spawn EINVAL error#147
Merged
Conversation
Spawning .cmd files (npm.cmd/npx.cmd) on Windows requires shell: true. Set shell conditionally based on platform to fix CI desktop builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Also fix npx binary name for Windows (.cmd extension required) and enable shell mode on Windows for both cli.mjs and native-runtime.mjs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn EINVALerror when building Windows desktop app in CI.cmdfiles (npm.cmd/npx.cmd) requireshell: trueto be spawned by Node.jschild_process.spawn()shell: falsetoshell: process.platform === 'win32'inelectron/cli.mjsso Windows CI builds work while macOS/Linux remain unaffectedTest plan
desktop-release.yml) completes successfully in CI🤖 Generated with Claude Code