Skip to content

Feat: add cron job for typing quality check#462

Merged
xingyaoww merged 2 commits intomainfrom
feat-add-cron-job-for-typing-quality-check
Sep 24, 2025
Merged

Feat: add cron job for typing quality check#462
xingyaoww merged 2 commits intomainfrom
feat-add-cron-job-for-typing-quality-check

Conversation

@simonrosenberg
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this might get automatically handled by pre-commit after this PR #465?

@simonrosenberg
Copy link
Copy Markdown
Collaborator Author

simonrosenberg commented Sep 24, 2025

Actually I think this might get automatically handled by pre-commit after this PR #465?

No, this PR adds a cron job that makes this issue every week #460
"The codebase contains multiple instances of vague types and union return types that force callers to manually narrow types via if/else or assert. "
I dont think that this is detectable by static tools. Sometimes a variable should be allowed to be optional, right? But if it's supposed to be well defined during runtime it should not be optional.

My hope is that this cron-job issue does meaningful code simplifications.

Copy link
Copy Markdown
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it, make sense!

@xingyaoww xingyaoww merged commit dceb495 into main Sep 24, 2025
14 checks passed
@xingyaoww xingyaoww deleted the feat-add-cron-job-for-typing-quality-check branch September 24, 2025 15:49
@simonrosenberg
Copy link
Copy Markdown
Collaborator Author

ah got it, make sense!

And this is the "output" of the issue #461
It fixed the multiple output create which is good but didn't pick up the issue with self.executor: Executor | None
I will make the same issue exactly. tag openhands again and see if it suggests other improvements

@github-actions
Copy link
Copy Markdown
Contributor

Agent Server image for this PR

Pull (multi-arch manifest):

docker pull ghcr.io/all-hands-ai/agent-server:b222f83

Run:

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-b222f83 \
  ghcr.io/all-hands-ai/agent-server:b222f83

This tag is a multi-arch manifest (amd64/arm64). Your client pulls the right arch automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants