fix: handle empty body in GitHub issue resolver#13039
Merged
malhotra5 merged 2 commits intoOpenHands:mainfrom Mar 18, 2026
Merged
fix: handle empty body in GitHub issue resolver#13039malhotra5 merged 2 commits intoOpenHands:mainfrom
malhotra5 merged 2 commits intoOpenHands:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13023
Problem
When an issue or PR has a
Nonebody (e.g. the user left the description empty), the resolver could crash with aNoneTypeerror during string concatenation or regex operations inissue_definitions.py.While individual handlers (GitHub, GitLab, etc.) each had their own
None→''guards, these were inconsistent and any new handler could easily miss this check.Fix
Added a Pydantic
field_validatoronIssue.bodythat coercesNoneto''before validation, and set the default to''. This provides a single, centralized safety net at the model level regardless of which handler creates theIssue.