fix: add claude-opus-4-6 to temperature/top_p guard#12874
Merged
enyst merged 1 commit intoOpenHands:mainfrom Feb 18, 2026
Merged
fix: add claude-opus-4-6 to temperature/top_p guard#12874enyst merged 1 commit intoOpenHands:mainfrom
enyst merged 1 commit intoOpenHands:mainfrom
Conversation
Anthropic's claude-opus-4-6 model rejects requests with both temperature and top_p set. Add it to the existing guard that drops top_p when both are specified, matching the existing handling for opus-4-1, opus-4-5, and sonnet-4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Clean fix that correctly extends the existing temperature/top_p guard. Implementation follows the established pattern and includes proper test coverage.
| or ('claude-opus-4-5' in _model_lower) | ||
| or ('claude-opus-4-6' in _model_lower) | ||
| or ('claude-sonnet-4' in _model_lower) | ||
| ) and ('temperature' in kwargs and 'top_p' in kwargs): |
Collaborator
There was a problem hiding this comment.
🟡 Suggestion: Consider a pattern-based check like "claude-opus-4" in _model_lower to automatically cover future 4.x versions without code changes. However, the explicit approach is safer if future versions might have different behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-opus-4-6to the existing model guard inopenhands/llm/llm.pythat dropstop_pwhen bothtemperatureandtop_pare specified (Anthropic rejects both for this model family)test_opus_46_keeps_temperature_drops_top_pFixes #12846
Test plan
test_opus_46_keeps_temperature_drops_top_ppasses🤖 Generated with Claude Code