Skip to content

fix(frontend): Respect HIDE_LLM_SETTINGS flag in settings modal#12400

Merged
raymyers merged 5 commits intoOpenHands:mainfrom
eureka0928:fix/hide-llm-settings-modal
Jan 14, 2026
Merged

fix(frontend): Respect HIDE_LLM_SETTINGS flag in settings modal#12400
raymyers merged 5 commits intoOpenHands:mainfrom
eureka0928:fix/hide-llm-settings-modal

Conversation

@eureka0928
Copy link
Copy Markdown
Contributor

@eureka0928 eureka0928 commented Jan 13, 2026 •
edited
Loading

Fixes #12272

Summary of PR

The AI Provider Configuration modal was appearing for new users even when HIDE_LLM_SETTINGS=true was set server-side. Added check for the feature flag before opening the modal.

Demo Screenshots/Videos

Video_2026_01_13-1.webm

Change Type

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Other (dependency update, docs, typo fixes, etc.)

Checklist

  • I have read and reviewed the code and I understand what the code is doing.
  • I have tested the code to the best of my ability and ensured it works as expected.

Fixes

Resolves #12272

Release Notes

  • Include this change in the Release Notes.

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=42954461

@eureka0928
fix(frontend): Respect HIDE_LLM_SETTINGS flag in settings modal
4a6c46f 
The AI Provider Configuration modal was appearing for new users even
when HIDE_LLM_SETTINGS=true was set server-side. Added check for the
feature flag before opening the modal.

Fixes OpenHands#12272
@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Jan 13, 2026

@mamoodi @raymyers @hieptl @malhotra5 would you review this PR?
Thank you

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Jan 13, 2026

This E2E test is failing on main branch, not related to my changes

{507D58E5-B5E2-4D4B-B8E8-97FAE6D90807}

hieptl
hieptl reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hieptl hieptl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @leonace924,

Thank you very much for creating this pull request. The changes look good to me.

We encourage adding tests to help improve code quality and prevent potential regressions. When you have a chance, would you mind adding tests to cover your changes?

Please feel free to let me know if you have any questions or need any support.

Thank you very much! 🙏

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Jan 14, 2026 •
edited
Loading

@hieptl I added the testing, can you review please?
Also, if you have any other issue, please assign to me
Thank you

@eureka0928
refactor(test): improve sidebar test coverage and reduce duplication
c18fb50 
   Add createMockConfig helper to reduce boilerplate in test mocks.
   Add test case for /settings path behavior where modal should not open.
   Rename RouterStub to ConversationRouterStub for clarity.
@eureka0928
fix linting
33c0ea1
@eureka0928 eureka0928 force-pushed the fix/hide-llm-settings-modal branch from 2a9d0bd to f69fbf0 Compare January 14, 2026 15:56
@eureka0928 eureka0928 requested a review from hieptl January 14, 2026 15:57
@eureka0928
fix(test): make avatar menu E2E test more reliable
062e8f0 
Use click-to-toggle instead of CSS hover to open the menu, which is
more reliable in automated tests. Key fixes:
@eureka0928 eureka0928 force-pushed the fix/hide-llm-settings-modal branch from f69fbf0 to 062e8f0 Compare January 14, 2026 22:31
@raymyers
Copy link
Copy Markdown
Contributor

raymyers commented Jan 14, 2026

Thanks for adding the tests and looking at that e2e as well.

@raymyers raymyers merged commit 3c6edfe into OpenHands:main Jan 14, 2026
19 checks passed
@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Jan 14, 2026

Hi @raymyers thank you
Would you assign me one more ticket?

@eureka0928 eureka0928 deleted the fix/hide-llm-settings-modal branch April 12, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymyers raymyers raymyers approved these changes

@amanape amanape Awaiting requested review from amanape

@hieptl hieptl Awaiting requested review from hieptl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: HIDE_LLM_SETTINGS=true does not prevent "AI Provider Configuration" modal from appearing

3 participants

@eureka0928 @raymyers @hieptl