fix(frontend): add missing onClose prop to conversation panel modals#12219
Merged
amanape merged 4 commits intoOpenHands:mainfrom Dec 31, 2025
Merged
Conversation
amanape
approved these changes
Dec 31, 2025
Contributor
amanape
left a comment
There was a problem hiding this comment.
Thank you for opening this PR! I’ve added missing tests and confirmed they are valid by undoing your changes and confirming those tests fail. For the future, please add some test coverage, preferably via TDD.
Thank you and happy new year 🎉!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR
This PR ensures that confirmation modals in the conversation panel (ConfirmDeleteModal, ConfirmStopModal, and ExitConversationModal) can be dismissed by clicking the dark backdrop or pressing the Escape key. This maintains UI consistency across the application by properly passing the onCancel/onClose handlers to the ModalBackdrop component.
Change Type
Checklist
Fixes
Resolves #12205
Release Notes
Added missing onClose functionality to conversation panel modals, allowing them to be dismissed via backdrop click or Escape key.