refactor(frontend): remove HeroUI BaseModal and migrate MetricsModal#12174
Merged
amanape merged 3 commits intoOpenHands:mainfrom Dec 31, 2025
Merged
Conversation
amanape
suggested changes
Dec 27, 2025
Contributor
amanape
left a comment
There was a problem hiding this comment.
Thank you for opening a PR. I noticed this issue while testing your changes:
Compared to the old style:
The biggest issue being that the modal content is "squashed" to the left rather than centered
Contributor
Author
|
Can you please tell me in which environment you took the screenshot? Because I viewed the modal in multiple browsers and on different screen sizes and it did not appear as in the screenshot. Thanks in advance. @amanape |
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
|
Could you please share a screenshot of the changes on your side? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #12173
Summary of PR
This PR standardizes modal usage by migrating
MetricsModalfrom the HeroUIModalcomponent to the existing custom modal system (
ModalBackdrop+ModalBody).This removes the last remaining usage of HeroUI modals, reducing duplicated logic
and ensuring consistent modal behavior and styling across the application.
Change Type
Checklist
Fixes
Resolves #12173
Release Notes